IME composition Vue merged

Misskey chat sends the message on the Enter that confirms a Japanese IME conversion (Vue)

Chat composer sends the message on the Enter that confirms an IME conversion

Misskey · misskey-dev/misskey

Symptom

With send-on-Enter enabled, the chat composer's onKeydown calls send() without checking the IME, so the Enter that confirms a Japanese conversion sends the in-progress text and clears the input.

Minimal repro
1. Open the chat room composer with send-on-Enter enabled.
2. With a Japanese IME, type some hiragana and press Space to get conversion candidates.
3. Press Enter to choose a candidate.
4. The unconfirmed text is sent instead of the conversion committing.
Fix

Return early in the keydown handler while the IME is composing (ev.isComposing || ev.key === 'Process' || ev.keyCode === 229), matching MkInput, MkTextarea, and MkCodeEditor.

Merged PR → #misskey-chat-enter-ime

Also in: Vue

← all 97 entries